Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a pre-commit config that runs with the defines used for major projects (and run once) #793

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add a pre-commit config that runs with the defines used for major projects (and run once) #793

wants to merge 2 commits into from

Conversation

mikeage
Copy link
Member

@mikeage mikeage commented Dec 6, 2024

Run with pre-commit run -a -c .pre-commit-config-defines.yaml

This is not enabled by default, because the code, which is rather
convoluted due to the inability to pass --define to dotnet format,
coupled with our files' containing BOMs, doesn't run on Windows.

@mikeage
Add a pre-commit config to run with the specific defines of major pro…
b31c5fb 
…jects

Run with pre-commit run -a -c .pre-commit-config-defines.yaml

This is not enabled by default, because the code, which is rather
convoluted due to the inability to pass --define to dotnet format,
coupled with our files' containing BOMs, doesn't run on Windows. It
barely runs on Linux, tbh ;-)
@mikeage
Run pre-commit one time with actual defines
f2bfd9e
@mikeage mikeage added the infrastructure Build or tooling infrastructure label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
infrastructure Build or tooling infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikeage